Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter_config_dir - reorder home_dir initialization #251

merged 1 commit into from Feb 15, 2022


Copy link

This PR moves the initialization of the home_dir variable, so that this logic will not get hit if JUPYTER_CONFIG_DIR or JUPYTER_NO_CONFIG are set in the environment (this helps to avoid any OS level issues accessing or resolving default file paths when the config directory path is already being set explicitly as an environment variable)

Copy link

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dharmaquark!

@blink1073 blink1073 merged commit 5f02097 into jupyter:master Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants