Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_hidden: Use normalized paths #271

merged 1 commit into from Jun 22, 2022


Copy link

The current is_hidden implementation considers the path path/to/my/./file.txt to be hidden, while it's not. This PR fixes it by normalizing the paths prior to compute the is_hidden logic.

Similar fix in jupyter_server jupyter-server/jupyter_server#886

Copy link

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@blink1073 blink1073 merged commit bc6b771 into jupyter:main Jun 22, 2022
@martinRenou martinRenou deleted the is_hidden_use_normalized_paths branch June 23, 2022 06:48
@blink1073 blink1073 added the bug label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants