Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A zsh autocompleter for jupyter. #48

Merged
merged 1 commit into from
Aug 28, 2015
Merged

A zsh autocompleter for jupyter. #48

merged 1 commit into from
Aug 28, 2015

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Aug 26, 2015

See #47.

@Carreau
Copy link
Member

Carreau commented Aug 27, 2015

Note to check wether setup.py include that in the sdist (and wheel?) before merging.

+1 otherwise.

@anntzer
Copy link
Contributor Author

anntzer commented Aug 27, 2015

Doesn't seem to be included. Not really sure whether it should be or not: either you can have the users include the folder in their $fpath (in .zshrc/.zprofile), or rely on the downstream packages to dump the file in (e.g., for Arch) /usr/share/zsh/functions/Completion/...

@Carreau
Copy link
Member

Carreau commented Aug 27, 2015

don't worry we'll modify setup.py to at least include that in sdist. I just
dropped the line as a reminder for us.

On Thu, Aug 27, 2015 at 10:32 AM, Antony Lee notifications@github.com
wrote:

Doesn't seem to be included. Not really sure whether it should be or not:
either you can have the users include the folder in their $fpath (in
.zshrc/.zprofile), or rely on the downstream packages to dump the file in
(e.g., for Arch) /usr/share/zsh/functions/Completion/...


Reply to this email directly or view it on GitHub
#48 (comment).

Carreau added a commit that referenced this pull request Aug 28, 2015
A zsh autocompleter for jupyter.
@Carreau Carreau merged commit 9ebcf63 into jupyter:master Aug 28, 2015
@minrk minrk added this to the 4.0.5 milestone Mar 7, 2016
@anntzer anntzer deleted the zsh-autocomplete branch June 25, 2016 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants