Enable adding listeners to event before the event is registered #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
force-pushed
the
pre-flight-listeners
branch
from
5672f18
to
654f474
Compare
Zsailer
force-pushed
the
pre-flight-listeners
branch
from
654f474
to
7bbacaa
Compare
|
I don't understand why the pre-release tests are failing while all the other tests are passing. The test that is failing is actually doing what it's suppose to do... raise a |
|
Found the issue. I didn't realize that |
davidbrochart
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if listeners are added before the event they are meant to watch is added, the listener gets removed when the event is registered. We should keep them around.
This showed up in work around jupyter server.
If one extension (E1) wants to listen to events from another extension (E2), a problem arises is E2 is loaded after E1 is loaded. This is a common use-case. jupyter server doesn't have a dependency injection system yet, so we can't name extension dependencies.
Either way, I think the event logger show allow listeners to be added even if the event isn't registered yet. It's a no-op until the event is registered.