Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new kernel management modules #41

Merged
merged 5 commits into from
Sep 18, 2018
Merged

Use new kernel management modules #41

merged 5 commits into from
Sep 18, 2018

Conversation

takluyver
Copy link
Member

Switch from jupyter_client to the new modules I'm working on: jupyter_kernel_mgmt and jupyter_protocol.

This means that the kernel to be tested no longer needs a kernelspec installed. By default it will still look for one, but you can override the launch_kernel classmethod to do something like this:

@classmethod
def launch_kernel(cls):
    from jupyter_kernel_mgmt.subproc import SubprocessKernelLauncher
    launcher = SubprocessKernelLauncher(['python', '-m', 'ipykernel', '{connection_file}'])
    return launcher.launch()

I made changes to both jupyter_kernel_mgmt and jupyter_protocol while working on this, so you probably want to get an updated version if you want to test it.

@rgbkrk
Copy link
Member

rgbkrk commented Jul 2, 2018

Sweet.

@minrk minrk merged commit 41850aa into master Sep 18, 2018
@SylvainCorlay SylvainCorlay deleted the new-kernel-mods branch September 18, 2018 09:27
blink1073 added a commit to blink1073/jupyter_kernel_test that referenced this pull request Nov 23, 2021
This reverts commit 41850aa, reversing
changes made to 0b78c28.
@blink1073 blink1073 added this to the 0.4 milestone Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants