reorder preprocessors #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -227,6 +229,7 @@ def _init_preprocessors(self): | |||
| # Load user-specified preprocessors. Enable by default. | |||
| for preprocessor in self.preprocessors: | |||
| self.register_preprocessor(preprocessor, enabled=True) | |||
| print([ p for p in self._preprocessors ]) | |||
- ensure execute runs first - ensure extract output runs last Any operations on outputs are incorrect if done before execute. Similarly, any modifications should be done before extraction.
minrk
force-pushed
the
preprocessor-order
branch
from
7e48eb3
to
644a311
Compare
|
Merged - I'll have a go at the backport. |
takluyver
added a commit
to takluyver/ipython
that referenced
this pull request
Apr 30, 2015
Backport of jupyter/nbconvert#14 to 3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any operations on outputs are incorrect if done before execute. Similarly, any modifications should be done before extraction.
Thanks @olgabot for revealing the problem.
This should be backported for IPython 3.x.