Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Batch 5] Porting Notebook PRs #103

Merged
merged 5 commits into from
Sep 27, 2019
Merged

[Batch 5] Porting Notebook PRs #103

merged 5 commits into from
Sep 27, 2019

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Sep 27, 2019

kevin-bates
kevin-bates reviewed Sep 27, 2019
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zach. Had the one comment about selenium tests.

Could you also rebase against master since conflicts will prevent the merge?

jupyter_server/tests/selenium/test_multiselect.py Outdated Show resolved Hide resolved
EvgeniDubov and others added 4 commits September 27, 2019 10:11
@EvgeniDubov @Zsailer
changing file name to lower case before checking if file extension is…
fdad83c 
… ipynb
@takluyver @Zsailer
Call tornado WebSocketHandler.get() as a coroutine
e1b5985 
This change will probably be needed for Tornado 6. Ben Darnell figured it out.
https://groups.google.com/d/msg/python-tornado/mSeG7Kc6z4o/baeTDOvJGgAJ
@kevin-bates @Zsailer
Enable restart_kernel for async usage
97fbda8 
Converted `MappingKernelManager.restart_kernel` to a coroutine so that
projects that take advantage of async kernel startup can also realize
appropriate behavior relative to restarts.
@fchapoton @Zsailer
remove unused import of os
0060310 
found by lgtm
@Zsailer
Copy link
Member Author

Zsailer commented Sep 27, 2019

Rebased.

kevin-bates
kevin-bates approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin-bates kevin-bates merged commit cbf8b5b into jupyter-server:master Sep 27, 2019
@kevin-bates
Copy link
Member

No cleanup necessary.

@Zsailer Zsailer deleted the batch-5 branch January 10, 2020 17:35
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
Clean up JS tests (jupyter-server#103)
9b20103 
* clean up JS tests

* more cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Zsailer @kevin-bates @EvgeniDubov @takluyver @fchapoton