List hidden files if allowed #4328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhirschfeld
reviewed
Jan 8, 2019
| @@ -334,7 +334,7 @@ def _dir_model(self, path, content=True): | |||
| self.log.debug("%s not a regular file", os_path) | |||
| continue | |||
|
|
|||
| if self.should_list(name) and not is_file_hidden(os_path, stat_res=st): | |||
| if self.should_list(name) and ((not is_file_hidden(os_path, stat_res=st)) or self.allow_hidden): | |||
| contents.append(self.get( | |||
| path='%s/%s' % (path, name), | |||
| content=False) | |||
There was a problem hiding this comment.
The logic might be clearer split over a couple of lines:
if self.should_list(name):
if self.allow_hidden or not is_file_hidden(os_path, stat_res=st):
contents.append(
self.get(path='%s/%s' % (path, name), content=False)
)
|
ping @yuvipanda! Since you asked on gitter I think all that is required is for someone to review and merge this PR. |
|
Thanks! |
This was referenced Sep 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #3812 and jupyterlab/jupyterlab#2049.
If the listing of hidden files and directory is allowed, then we return them in the
api/contents/:call so that they are displayed in the file manager of the notebook and lab interfaces.I am not sure about the code style. Feel free to suggest a better way, if any.