Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a minimal login page with info #295

Merged
merged 2 commits into from
Aug 31, 2020

Conversation

blink1073
Copy link
Collaborator

@blink1073 blink1073 commented Aug 31, 2020

Partial fix for #271

image

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Zsailer Zsailer merged commit 28d82ab into jupyter-server:master Aug 31, 2020
@jasongrout
Copy link
Contributor

You support setting a password too, just like classic notebook. Nice!

@jasongrout
Copy link
Contributor

Does this also fix #271 ?

@blink1073
Copy link
Collaborator Author

blink1073 commented Aug 31, 2020

I'd say it does not quite style the page, so let's leave #271 open

@blink1073 blink1073 added this to the 1.0 Release milestone Sep 17, 2020
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants