Drop support for python 3.5 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When was this decided? |
|
Duh: jupyterlab/jupyterlab#8903 Sometimes I don't know where my head is :) |
|
😄 |
|
Oh, I think the reason I didn't push that change down to this level is that Notebook 6 supports python 3.5, and I thought we wanted nbclassic to be a drop-in replacement. So I thought that supporting python 3.5 was deliberate for jupyter_server to make sure people could migrate off notebook. |
|
I think since Python 3.5 reaches end-of-life on 9/13, we can ask that people move off in jupyter_server and Notebook at this point. I'm planning to submit a PR to remove Python 3.5 from Notebook too. |
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
Drop support for python 3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JupyterLab is dropping support for Python 3.5 in 3.0, see also https://numpy.org/neps/nep-0029-deprecation_policy.html