Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Batch 3] Porting Notebook PRs #98

Merged
merged 7 commits into from
Sep 25, 2019
Merged

Conversation

kevin-bates and others added 6 commits September 25, 2019 14:59
Recently I needed to troubleshoot kernel responses and found it helpful
to distinguish status types (busy vs. idle) - thought others might find
it useful as well.

Entries that previously appeared as...
```
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_input
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: display_data
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_result
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status
```
will now appear as...
```
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle)
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (busy)
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle)
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (busy)
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_input
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: display_data
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_result
 activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle)
```
This allows slower contents managers to not block the event loop by allowing
more of their API to return futures.

Other usages of contents manager functions are already wrapped in maybe_future,
including a use of `file_exists` in contents/handlers.py
Currently the default URL message given on the console on startup is:

---
Copy/paste this URL into your browser when you connect for the first time,
    to login with a token:
        http://(myip.com or 127.0.0.1):8888/?token=8fdc8 ...
---

This will always need editing to use. Replace with host IP (e.g. 'myip.com')
to make it copy/pastable again.
Currently the default URL message given on the console on startup is:

---
Copy/paste this URL into your browser when you connect for the first time,
to login with a token:
     http://(myip.com or 127.0.0.1):8888/?token=8fdc8 ...
---

This will always need editing to use. Replace with one host IP (e.g. 'myip.com')
option and one local ip (127.0.0.1) option to make it copy/pastable again.
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, but I believe we have an issue introduced in batch-2 where the prometheus tests are failing due to an import reference. Let's patch those files prior to merging this.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the quick updates.

@kevin-bates kevin-bates merged commit 1f31046 into jupyter-server:master Sep 25, 2019
@vidartf vidartf mentioned this pull request Sep 26, 2019
5 tasks
@Zsailer Zsailer deleted the batch-3 branch January 10, 2020 17:35
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
* add config for deployment

* Bump to 0.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants