This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Revamp the entry option and add an outputDir option to build configurations #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations. The entry option should be a module, not necessarily a path, so we clarify the name. We also often need to specify the output directory, so we abstract over the webpack config for the user. Fixes jupyter#8.
There is enough variability in where people want to put the generated files that we shouldn’t have magic default values. It should be very explicit.
|
Seems to work well. @blink1073, this is ready for review. |
jasongrout
changed the title
|
cf #8. |
|
We'll need to bump to 0.4.0 after this is merged since it is an incompatible change. |
|
Looks good, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entry option should be a module, not necessarily a path, so we clarify the name.
We also often need to specify the output directory, so we abstract over the webpack config for the user.
TODO: