Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Horizontal Scrollbar 1/2 hidden #815

Closed
Carreau opened this issue Aug 31, 2016 · 9 comments
Closed

Editor: Horizontal Scrollbar 1/2 hidden #815

Carreau opened this issue Aug 31, 2016 · 9 comments
Assignees
Labels
bug pkg:fileeditor status:Needs Info status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Milestone

Comments

@Carreau
Copy link
Contributor

Carreau commented Aug 31, 2016

When a line is sufficiently long to trigger the horizontal scrollbar to appear it is 1/2 hidden (on Mac OS 10.10.3, Chrome 53)

screen shot 2016-08-30 at 19 15 40

@sccolbert
Copy link
Contributor

Do you think this is something we're doing, or a code mirror issue?

@Carreau
Copy link
Contributor Author

Carreau commented Aug 31, 2016

I think it is due to the 4 pitel top margin on the editor:

.jp-EditorWidget {
    border-top: 1px solid #E0E0E0;
    margin-top: 4px;  // this one
}

Removing it for fixes things though I doubt it's the right fix as it removes the 4 pixel border at top conveying it's a panel.
In general the .jp-EditrWidget seem to overflow by a few pixel at the bottom from it's containing p-Widget p-Panel p-StackedPanel p-TabPanel-stackedPanel you can see that when hovering the dom element in the inspector; attempt at a screenshot:

screen shot 2016-08-31 at 08 58 04

Does that make sens ?

@sccolbert
Copy link
Contributor

Yep. This is our CSS bug.

cc @afshin

@afshin afshin added this to the 0.90 milestone Sep 2, 2016
@afshin
Copy link
Member

afshin commented Sep 6, 2016

I can't reproduce this. Perhaps a different CSS fix has resolved this.

In the text editor I get line wrapping:

editor

In the console, I can see the full scrollbar:

console

And in the notebook, I can see the full scrollbar:

notebook

@Carreau, could you please confirm if this is still happening for you?

@sccolbert
Copy link
Contributor

sccolbert commented Sep 6, 2016

@afshin It looks like the issue is with the horizontal scrollbar on the text editor being clipped. Not the code cells.

@sccolbert
Copy link
Contributor

also, I don't think line-wrapping on the text editor is a good default. But maybe i'm in the minority there.

@afshin
Copy link
Member

afshin commented Sep 6, 2016

@sccolbert yeah, I just couldn't generate a horizontal scrollbar on the editor.

@jasongrout
Copy link
Contributor

also, I don't think line-wrapping on the text editor is a good default. But maybe i'm in the minority there.

For me, it depends a lot on the filetype. I look forward to our settings system so we can have per-filetype wrapping.

@afshin
Copy link
Member

afshin commented Sep 29, 2016

Closing because there hasn't been an update in a while; I couldn't reproduce it and it didn't arise again as an issue.

@afshin afshin closed this as completed Sep 29, 2016
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:fileeditor status:Needs Info status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Projects
None yet
Development

No branches or pull requests

5 participants