-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only parse and display a limited number of rows #976
Comments
Pinging @sccolbert as this will be solved in a better way by the grid widget he is building... |
While we are doing this, let's also put the table header and body in |
I can tackle this, or the For the partial parsing, is this really needed for the demo? If we do it, are we actually needing to implement a virtual renderer here? I assume you'd still want to be able to scroll through the entire data set? |
I checked the docs for d3, and it always parses the entire file. We can dynamically choose which of those rows to render based on scroll position, but IMO that should wait until we have a grid widget. I think the best we can do now is set a hard limit on the number of rows and console warn if it is above a certain number. |
Fixed for now in master... |
Right now the CSV widget blindly parses the entire file and tries to display it. The d3 parsing library we have can parse only certain lines of a file. We should only parse and display the first N lines of a CSV file, where N is a number we play with to see where performance problems hit. Guessing that 500-1000 is a good start...
The text was updated successfully, but these errors were encountered: