Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move language_info retrieval before cell execution #102

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Move language_info retrieval before cell execution #102

merged 1 commit into from
Aug 26, 2020

Conversation

davidbrochart
Copy link
Member

Fixes #101

@chrisjsewell
Copy link
Contributor

thanks @davidbrochart 😄

@MSeal
Copy link
Contributor

MSeal commented Aug 26, 2020

@davidbrochart do you know if there's any potential issues switching this ordering may have? I think it's fine to do but I wanted to float the question before we merge.

@davidbrochart
Copy link
Member Author

I don't see any potential issue, but I also wanted to know your thoughts 😄

MSeal
MSeal approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try then :)

@davidbrochart davidbrochart merged commit 1431476 into jupyter:master Aug 26, 2020
@davidbrochart davidbrochart deleted the kernel_info branch August 26, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSeal MSeal MSeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kernal info retrieval fails on small VMs
3 participants
@davidbrochart @chrisjsewell @MSeal