Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for ipykernel without debugpy #166

Merged

Conversation

frenzymadness
Copy link
Contributor

It is supported by ipykernel to run it without debugpy installed
but it produces warnings informing about disabled debugging.
Those warnings should not cause tests of nbclient to fail.

See: https://github.com/ipython/ipykernel/blob/1ba6b48a97877ff7a564af32c531618efb7d2a57/ipykernel/ipkernel.py#L36

It is supported by ipykernel to run it without debugpy installed
but it produces warnings informing about disabled debugging.
Those warnings should not cause tests of nbclient to fail.
@SylvainCorlay
Copy link
Member

I am fine with this change, although still a bit unsure of how much the code base should take into account that some package managers remove a dependency.

@frenzymadness
Copy link
Contributor Author

The pre-commit check complains about a file I haven't touched here. Also, the failure of 3.9 on macos seems unrelated.

I am fine with this change, although still a bit unsure of how much the code base should take into account that some package managers remove a dependency.

I understand. In Fedora, we are running tests in RPM build and because we ship ipykernel without debugpy, the tests are failing. We can either fix it here or on the RPM level and because the fix is easy and might be useful also for other warnings/errors in the future, I've proposed it.

@davidbrochart
Copy link
Member

The pre-commit check complains about a file I haven't touched here.

Fixed.

Also, the failure of 3.9 on macos seems unrelated.

Yes, it's unrelated.

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@frenzymadness
Copy link
Contributor Author

Could this be merged? Or can I do something to move it forward?

@davidbrochart davidbrochart merged commit 522cec7 into jupyter:master Oct 25, 2021
@davidbrochart
Copy link
Member

Thanks!

@SylvainCorlay
Copy link
Member

@frenzymadness would you consider packaging debugpy on fedora, so that eventually everything is maintained.

@frenzymadness
Copy link
Contributor Author

@frenzymadness would you consider packaging debugpy on fedora, so that eventually everything is maintained.

I've tried that but the package is very complex and at that time it had only partial support for Python 3.10. I'll definitely try it once again soon.

@frenzymadness frenzymadness deleted the allow_ipykernel_without_debugpy branch October 26, 2021 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants