Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding changelog in docs #22

Merged
merged 1 commit into from
Feb 17, 2020
Merged

adding changelog in docs #22

merged 1 commit into from
Feb 17, 2020

Conversation

choldgraf
Copy link
Contributor

closes #20

@MSeal does this look reasonable?

Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MSeal
Copy link
Contributor

MSeal commented Feb 16, 2020

Docs builds failed with an odd error. Looks almost like it just failed talking to PyPI

@MSeal
Copy link
Contributor

MSeal commented Feb 16, 2020

I restarted the jobs

@choldgraf
Copy link
Contributor Author

I think the errors were because we had pinned to an older version of recommonmark...but I just removed the pin and it seems to be happy. Is there a strong reason we were using the 0.4 version before?

@MSeal
Copy link
Contributor

MSeal commented Feb 17, 2020

I believe there was a bug with the most recent version or a python 2 specific reason (this was copied from another project), but I can't recall. If it works now to unpin +1

@MSeal MSeal merged commit e6849c0 into jupyter:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make task for copying changelogs to readthedocs page
2 participants