New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send KeyboardInterrupt a little later in test_run_all_notebooks[Interrupt.ipynb-opts6] #285
Conversation
I don't understand the issue. Can you run |
Here is the output from
Due to the restrictive 1s timeout, the keyboard interrupt is sent before the program enters the infinite loop. |
This test is failing on riscv64 linux boards because the interrupt happens too soon. Build log: https://archriscv.felixc.at/.status/log.htm?url=logs/jupyter-nbclient/jupyter-nbclient-0.7.3-1.log
Hi, is there any unsettled issues about this PR? |
The test is failing on riscv64 linux boards because the KeyboardInterrupt happens too soon. (before the program enters the infinite loop) Upstream PR: jupyter/nbclient#285
The test is failing on riscv64 linux boards because the KeyboardInterrupt happens too soon. (before the program enters the infinite loop) Upstream PR: jupyter/nbclient#285
I'm not convinced this is the issue. The |
Hi @davidbrochart . You are right. I added a print statement inside the while loop and it shows that the program indeed enters the infinite loop. But sending the interrupt a little later do solve the test failure, which I don't quite understand. As you mentioned in ipython/ipykernel#845 that you can't reproduce this issue. I can provide a way that reproduces this issue 100% of time on riscv64 emulators(Of course, it is also reproducible on real boards).
|
I can reproduce using the setup you described, and I also don't understand. I suspect that it's related to this "machine" being slower (which could also explain why it sometimes fail in the CI), but I can't figure out where this is coming from. |
This test is failing on riscv64 linux boards because
the interrupt happens too soon. Build log:
https://archriscv.felixc.at/.status/log.htm?url=logs/jupyter-nbclient/jupyter-nbclient-0.7.3-1.log