Fix nested event loops execution #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
As we don't have the Binder repo merged yet it's a bit hard to know if that fixes the problem, but I did try running @davidbrochart 's branch on Binder here: https://mybinder.org/v2/gh/davidbrochart/nbclient/56a1b042499673026759f43807e6169a69541aae then created a notebook and used nbclient to execute it, and it worked! So +1 from me |
MSeal
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
RuntimeError: This event loop is already runningwhennbclient.executeis run in an environment where an event loop is already running (e.g. Binder). See #7 (comment).