Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'store_history' option to 'preprocess_cell' and 'run_cell' #1055

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

wwitzel
Copy link
Contributor

@wwitzel wwitzel commented Jun 26, 2019

…methods of ExecutePreprocessor.

The default value is True to be backwards compatible since the default of KernelClient.execute has store_history=True. Allowing "store_history" to be disabled can be valuable when "hacking" nbconvert to execute many notebooks with one Kernel session and not store memory along the way that is not needed.

@MSeal
Copy link
Contributor

MSeal commented Jul 5, 2019

Thanks for the change. For others looking see #1032 for context.

I'm going to make a new issue to change the default to False for nbconvert 6.0 release which will be a later release.

@MSeal MSeal merged commit 05404d0 into jupyter:master Jul 5, 2019
@MSeal MSeal added this to the 5.6 milestone Jul 30, 2019
@meeseeksmachine
Copy link

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/nbconvert-5-6-0-release/1867/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants