Define missing tokens. #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need a test. Closes jupyter/notebook#466 (and maybe a few other PRs)
|
@Carreau I'm going to assume that since you made another Issue for the tests, this should be merged now. Merging away... |
|
I don't actually know how this passed — when I run nosetests locally on using ipython I get three errors running |
|
Do you want to make a PR in nbconvert/tests/test_nbconvertapp.py that make the test fails to see if travis fail ? Cause the test should be included in travis testing. There might be a skipif when tex not included. |
|
I get 185 test locally 1 fail. |
|
Reverting something wrong with my system, this is not actually needed, and travis does not test PDF. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need a test.
Closes jupyter/notebook#466
(and maybe a few other PRs)