Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak exporter default_config merging behavior #1981

Merged
merged 3 commits into from
May 6, 2023
Merged

Tweak exporter default_config merging behavior #1981

merged 3 commits into from
May 6, 2023

Conversation

tuncbkose
Copy link
Contributor

@tuncbkose tuncbkose commented Apr 21, 2023 •
edited
Loading

Re #1980, changes Config merging so that child configuration overwrites parent configuration as opposed to the other way around.

Closes #1980

@krassowski krassowski added the bug label Apr 22, 2023
@krassowski
Copy link
Member

I think this looks good. Should there be a unit test for the changed behaviour (when there are keys in both parent and child)?

@tuncbkose
Copy link
Contributor Author

Rebased with main

blink1073
blink1073 approved these changes May 6, 2023
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit d113388 into jupyter:main May 6, 2023
20 checks passed
@tuncbkose tuncbkose deleted the config_merge branch May 6, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exporter default_config merging
3 participants
@tuncbkose @krassowski @blink1073