Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruff config #2079

Merged
merged 6 commits into from Dec 12, 2023
Merged

Update ruff config #2079

merged 6 commits into from Dec 12, 2023

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 merged commit a7df9af into jupyter:main Dec 12, 2023
23 checks passed
@blink1073 blink1073 deleted the update-ruff branch December 12, 2023 13:23
@mgeier
Copy link
Contributor

mgeier commented Dec 21, 2023

In nbconvert/preprocessors/execute.py, this removed the backwards-compatibility line:

from nbclient.exceptions import CellExecutionError  # noqa

Was this intentional?

Interestingly, it did not remove the comment for that line:

# Backwards compatibility for imported name

See also spatialaudio/nbsphinx#466 (comment).

@mgeier mgeier mentioned this pull request Dec 21, 2023
Closed
@blink1073 blink1073 mentioned this pull request Dec 21, 2023
Merged
@blink1073
Copy link
Member Author

Thanks for reporting! I opened #2086.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blink1073 @mgeier