Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- changing mermaid suport #2120

Closed
wants to merge 10 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions nbconvert/exporters/slides.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,16 @@ def _reveal_url_prefix_default(self):
return self.config.RevealHelpPreprocessor.url_prefix
return "https://unpkg.com/reveal.js@4.0.2"

reveal_mermaid_js_url = Unicode(
help="Specifies the mermaid reveal plugin url.",
).tag(
config=True,
)

@default("reveal_mermaid_js_url")
def _reveal_mermaid_js_url(self):
return "https://cdn.jsdelivr.net/npm/reveal.js-mermaid-plugin@2.2.0"

reveal_theme = Unicode(
"simple",
help="""
Expand Down Expand Up @@ -206,4 +216,5 @@ def _init_resources(self, resources):
resources["reveal"]["number"] = self.reveal_number
resources["reveal"]["height"] = self.reveal_height
resources["reveal"]["width"] = self.reveal_width
resources["reveal"]["reveal_mermaid_js_url"] = self.reveal_mermaid_js_url
return resources
21 changes: 12 additions & 9 deletions share/templates/reveal/index.html.j2
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
{% from 'jupyter_widgets.html.j2' import jupyter_widgets %}

{% set reveal_url_prefix = resources.reveal.url_prefix | default('https://unpkg.com/reveal.js@4.0.2', true) %}
{% set reveal_mermaid_js_url = resources.reveal.reveal_mermaid_js_url | default("https://cdn.jsdelivr.net/npm/reveal.js-mermaid-plugin@2.2.0", true) %}

{% set reveal_theme = resources.reveal.theme | default('white', true) %}
{% set reveal_transition = resources.reveal.transition | default('slide', true) %}
{% set reveal_number = resources.reveal.number | default('', true) %}
Expand Down Expand Up @@ -33,10 +35,6 @@
<script src="{{ resources.require_js_url }}"></script>
{%- endblock html_head_js_requirejs -%}
{%- block html_head_js_mermaidjs -%}
<script type="module">
import mermaid from '{{ resources.mermaid_js_url }}';
mermaid.initialize({ startOnLoad: true });
</script>
{%- endblock html_head_js_mermaidjs -%}
{%- endblock html_head_js -%}

Expand Down Expand Up @@ -145,21 +143,26 @@ require(
},
[
"{{ reveal_url_prefix }}/dist/reveal.js",
"{{ reveal_url_prefix }}/plugin/notes/notes.js"
"{{ reveal_url_prefix }}/plugin/notes/notes.js",
{% if reveal_mermaid_js_url %}"{{ reveal_mermaid_js_url }}",{% endif %}
],

function(Reveal, RevealNotes){
function(Reveal,
RevealNotes,
{% if reveal_mermaid_js_url %}RevealMermaid,{% endif %}){
// Full list of configuration options available here: https://github.com/hakimel/reveal.js#configuration
Reveal.initialize({
controls: true,
progress: true,
history: true,
transition: "{{reveal_transition}}",
slideNumber: "{{reveal_number}}",
plugins: [RevealNotes],
plugins: [
RevealNotes,
{% if reveal_mermaid_js_url %}RevealMermaid,{% endif %}
],
width: {{reveal_width}},
height: {{reveal_height}},

height: {{reveal_height}},
});

var update = function(event){
Expand Down
Loading