Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag remove preprocessor #640

Merged
merged 8 commits into from Aug 8, 2017
Merged

Tag remove preprocessor #640

merged 8 commits into from Aug 8, 2017

Commits on Aug 7, 2017

  1. add tag preprocessors for all levels of filtering

    @mpacer
    mpacer committed Aug 7, 2017
    Copy the full SHA
    ec9ed84 View commit details
    Browse the repository at this point in the history

  2. Add to default enabled, make sure variable names match

    @mpacer
    mpacer committed Aug 7, 2017
    Copy the full SHA
    c5205c0 View commit details
    Browse the repository at this point in the history

  3. add test for correct behaviour

    @mpacer
    mpacer committed Aug 7, 2017
    Copy the full SHA
    51e9d02 View commit details
    Browse the repository at this point in the history

  4. tests now test correct behaviour, tests pass

    @mpacer
    mpacer committed Aug 7, 2017
    Copy the full SHA
    aa79f8d View commit details
    Browse the repository at this point in the history

  5. regularise traitlet name improve test formatting

    @mpacer
    mpacer committed Aug 7, 2017
    Copy the full SHA
    447f99c View commit details
    Browse the repository at this point in the history

  6. Respond to @takluyver's comments, simplify code, use sets not lists

    @mpacer
    mpacer committed Aug 7, 2017
    Copy the full SHA
    22486e0 View commit details
    Browse the repository at this point in the history

  7. Better help strings for traitlets

    @mpacer
    mpacer committed Aug 7, 2017
    Copy the full SHA
    9bb68c7 View commit details
    Browse the repository at this point in the history

  8. update test to add rather than append to the sets

    @mpacer
    mpacer committed Aug 7, 2017
    Copy the full SHA
    ff4d341 View commit details
    Browse the repository at this point in the history