Img filename metadata #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine to me. I might even go further and throw an error if two outputs in one notebook have the same filename. |
|
How does that check feel? It looked like |
takluyver
reviewed
Oct 13, 2017
| @@ -102,6 +106,13 @@ def preprocess_cell(self, cell, resources, cell_index): | |||
| out.metadata.setdefault('filenames', {}) | |||
| out.metadata['filenames'][mime_type] = filename | |||
|
|
|||
| if filename in resources['outputs']: | |||
| raise ValueError( | |||
| "Your filename: {} appears more than once. " | |||
There was a problem hiding this comment.
I think this message could be a bit clearer - imagine a user who has got a notebook from someone else and is trying to convert it. Even if someone wrote it themselves, they might accidentally duplicate a filename by copying a cell.
Let's mention that this is a filename associated with an output, which nbconvert is now saving to a separate file, and that the name has come from output metadata.
|
Love the detailed error message! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #671
this should overwrite files if they are already present.
It also will add an extension to the file if it is not already present.
I'm open to changing either of those behaviours.