Fixup kernel death detection #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test fails as of this commit. Adds KernelIsDead as child of RuntimeError
Adds private _is_alive method to raise KernelIsDead. Previously this was only being checked circuitously in the codepath where the kernel had no timeout. This should still be abstracted more cleanly but excitedly this works. This does not address the race condition for the test_startup_kernel_dead case.
now a new test breaks having to do with the msg not being defined. This makes the codepath much nicer and easier to follow.
mpacer
force-pushed
the
fixup_kernel_death_detection
branch
from
fe60c6b
to
9012bdf
Compare
MSeal
reviewed
Apr 24, 2019
nbconvert/preprocessors/execute.py
Outdated
| @@ -24,6 +24,8 @@ | |||
| from .base import Preprocessor | |||
| from ..utils.exceptions import ConversionException | |||
|
|
|||
| class KernelIsDead(RuntimeError): | |||
There was a problem hiding this comment.
KernelDied or KernelDiedError
MSeal
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues that came up in discussion with MSeal around how we're testing kernel deaths (inconsistency between my machine and his + travis' on one test).
This unveiled a broader issue with how we were detecting the death of kernels.