Try to get nbdime used by github

[vidartf]

No description provided.

[willingc]

Hi @bkeepers,

I enjoyed meeting you at the wont_fix unconference at GH a couple of weeks ago. It was a lovely event, and I like GH's direction with opensource.guide (I shared with hundreds of students at Hack Illinois this past weekend).

I wanted to follow up on a conversation with Lee and others about possibly seeing if GitHub could incorporate nbdime for diffing Jupyter/IPython notebooks that GitHub renders. Would you mind pointing us in the right direction of who/where we should formally share this request with at GH?

Thanks 😄

Carol

cc/ @minrk @vidartf

[sixers]

Is it possible to create a JavaScript extension for Github? One of the ways to do this is to fetch diff data via API, and just provide a GUI on top of Github. This way we're not dependent on Github implementing this feature, and we can also support multiple vendors, e.g. Gitlab.

[bkeepers]

Hey @willingc, it was great to meet you too!

support@github.com is the best place to send feature requests. Our support team does a great job of cataloging feature requests so our engineering teams can see them.

[willingc]

Thanks @bkeepers for the direction. We'll send it over formally (though I think it has been raised in some informal talks already).

[Analect]

For what it's worth, I added a comment to this thread over on Gitlab, since there are efforts underway there to try to get a basic notebook viewer implemented. It could be that @vidartf or @sixers above could enhance the conversation over there and discuss the possibilities of gitlab being able to leverage the nbdime accomplishments.

[Analect]

FYI. Basic implementation for viewing notebooks has been added to master on Gitlab here. Still may be worth engaging with them to get nbdime working on that platform.

[orionr]

Any progress on this? Having the ability to diff ipynb files in GitHub PRs would be huge.

[joelostblom]

There is now a GitLab issue for adding rich diff support to notebooks.

[amit1rrr]

I built ReviewNB GitHub App for Jupyter notebook code reviews. More about it here.

It renders visual diffs for notebook commits and pull requests & lets you write comments to discuss changes. Comments are ultimately posted back to GitHub PR for storage.

[gwincr11]

https://github.blog/changelog/2023-03-01-feature-preview-rich-jupyter-notebook-diffs/

[minrk]

Huzzah!

[gwincr11]

Congrats and thanks for building a cool tool. Hope to meet you at Jupyter Conf.