Fix pretty-print diff filtering for added/removed cells etc. #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhauls the pretty-print system in order to filter diffs properly according to ignore flags to diff. Also adds the
-d/--detailsflag to nbdiff for filtering similar to what is available innbshow.Possible breaking change in CLI arguments: Removed the
-dshort-hand for--decisionsto nbmerge, as it now conflicts with the--detailsflag's short-hand for diff filtering.Note that the filtering is still not fully applied for nbdiff-web, which should probably be solved in a different PR.
Fixes #303.