Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nbdiff-web-export to export HTML diff using just command line #552

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add nbdiff-web-export to export HTML diff using just command line #552

wants to merge 7 commits into from

Commits on Nov 24, 2020

  1. Add nbdiff-web-export to export a diff inside a rendered HTML 

    nbdiff-web-export --ouput-dir output ./nbdime/webapp/testnotebooks/remote.ipynb ./nbdime/webapp/testnotebooks/base.ipynb

or

nbdiff-web-export --output-dir output HEAD~1 HEAD

These would generate inside output directory
diff1.html
diff2.html
....
diffN.html
depending how many files has been changed

it would also drop nbdime.js in the output directory
Alternatively one can use --nbdime_url optional parameter to specify where to get nbdime.js
    @trams
    trams committed Nov 24, 2020
    Copy the full SHA
    a1f12b6 View commit details
    Browse the repository at this point in the history

  2. Fix missing file bug

    @trams
    trams committed Nov 24, 2020
    Copy the full SHA
    f38f36c View commit details
    Browse the repository at this point in the history

  3. Add the basic test nbdiff can handle missing files

    @trams
    trams committed Nov 24, 2020
    Copy the full SHA
    1dea358 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. Remove unrelated comment

    @trams
    trams committed Nov 25, 2020
    Copy the full SHA
    39c73ee View commit details
    Browse the repository at this point in the history

  2. nbdiff-web-export will embed the script if --nbdime-url is missing

    @trams
    trams committed Nov 25, 2020
    Copy the full SHA
    9785571 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. fix broken checkbox label link

    @vidartf
    vidartf committed Dec 18, 2020
    Copy the full SHA
    067c83e View commit details
    Browse the repository at this point in the history

  2. Align some of the changes with existign conventions 

    Important points:
- Allow for configuration of mathjax and hide unchanged defaults
- Fix read/write encodings so it works on Windows
- Add some error handling code if we end up with broken json for the diff view

Remaining TODO:
- Ensure we build and use a single bundle. Existing nbdime.js does not bundle all the things (fonts, and some chunked JS).
- Find and check a decent default for MathJax: Use CDN as default, or switch to using jupyter-renderer's mathjax3 bundled ?
    @vidartf
    vidartf committed Dec 18, 2020
    Copy the full SHA
    5b9e1ff View commit details
    Browse the repository at this point in the history