Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support python 3.10 #607

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Support python 3.10 #607

merged 3 commits into from
Oct 25, 2021

Conversation

kr0p07k1n
Copy link
Contributor

@kr0p07k1n kr0p07k1n commented Oct 24, 2021 •
edited

nbdime cannot currently be installed on Python 3.10 since the ensure_python method parses the version as float within the eval call. Following #528 I think the right approach was to simply use python_requires and remove ensure_python.

@vidartf
Copy link
Collaborator

vidartf commented Oct 25, 2021

Thanks!

@vidartf vidartf merged commit f16d448 into jupyter:master Oct 25, 2021
@cclauss cclauss mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kr0p07k1n @vidartf