Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make INFO text more readable in black terminal #615

Merged

Conversation

tallamjr
Copy link
Contributor

@tallamjr tallamjr commented Feb 4, 2022

As addressed in #240 the
headers are printed in BLUE, which is hard to read when using git
integration in a dark terminal.

This allows for the color to remain the same, but just to brighten it up
such that is more readable.

Refs:
- https://github.com/tartley/colorama/blob/34703ece90fc4996727adff31502bad8a8e88066/demos/demo03.py#L15

modified:   prettyprint.py

As addressed in jupyter#240 the
headers are printed in BLUE, which is hard to read when using git
integration in a dark terminal.

This allows for the color to remain the same, but just to brighten it up
such that is more readable.

Refs:
    - https://github.com/tartley/colorama/blob/34703ece90fc4996727adff31502bad8a8e88066/demos/demo03.py#L15

	modified:   prettyprint.py
@vidartf
Copy link
Collaborator

vidartf commented Feb 8, 2022

Hi! How does this look on terminals with bright backgrounds? Could you post some screenshots? Preferably also stating which platform/terminal the screenshots were taken on, as I know the colors used tend to differ.

@tallamjr
Copy link
Contributor Author

tallamjr commented Feb 9, 2022

Hi! How does this look on terminals with bright backgrounds? Could you post some screenshots? Preferably also stating which platform/terminal the screenshots were taken on, as I know the colors used tend to differ.

Hi @vidartf , sure, please see below the difference without (left) and with (right) the change:

Dark Background
Screenshot 2022-02-09 at 14 31 23

Light Background
Screenshot 2022-02-09 at 14 30 07

I am running on macOS.10.15.7 and the above terminal app is iterm2:v3.3.11. Unfortunately I am unable to test on other platforms since my Terminal.app on my mac seems to be busted and I do not have access to a linux box or windows machine.

Hope that is still useful.

@vidartf
Copy link
Collaborator

vidartf commented Feb 16, 2022

Can confirm improvement on Windows as well:

image

and in bright theme in Windows Terminal:

image

@vidartf vidartf merged commit 2db0b44 into jupyter:master Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants