Update typescript #641
Merged
Update typescript #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am working on another pr which uses newer typescript features, so I thought I would update it first. This pr updates to typescript 4.9 and fixes the resulting errors. It also sets up a stricter tsconfig_base which is used by all tsconfig files and fixes the resulting errors.
Reverts parameter renames, and removes tsconfig settings with the default values. Removes as error expected directives, and fixes typings in another way.
This forces type-only imports to be imported with `import type`
With jupyter_server 2.0, we cannot support launching with notebook. The tests can potentially be reenabled with notebook 7.0, as it is based on jupyter_server.
When there is a token, xsrf cookies/headers are ignored, so using it makes tests easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on another pr which uses newer typescript features, so I thought I would update it first. This pr updates to typescript 4.9 and fixes the resulting errors. It also sets up a stricter tsconfig_base which is used by all tsconfig files and fixes the resulting errors.