Jupyter server 2.0 compatability fixes #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick q @vidartf - are you planning on making an official release with this fix? I'd prefer to deploy from a released package if possible, so I'm curious what your plans are (no pressure, obviously, and very grateful for the fixes, just asking for planning purposes). |
|
Release is blocked on #650, not entirely sure when I'll have time for it. Lab already has a similar fix with some import inspection, so if someone else wants to give that a go that would be very much appreciated! |
|
Understood, no worries. Thanks!! |
fperez
added a commit
to fperez/datahub
that referenced
this pull request
Mar 14, 2023
Currently available nbdime (v3.1.1) is incompatible with jupyter server 2.0. See jupyter/nbdime#649 for more. Will disable this and revert to an official release once a compatible one becomes available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues related to missing xsrf values due to our use of
navigator.sendBeaconfor closing the web tools. Also fixes a deprecation warning for missingidentity_provider.