Replace mock with unittest.mock #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is available with Python 3.3 [1], and nbdime requires Python 3.6+ as per setup.py. This change removes the need of an external library. [1] https://docs.python.org/3/library/unittest.mock.html
|
This pull request is a preparation for adding python-nbdime package to Arch Linux, where it's encouraged to replace mock with unittest.mock: https://archlinux.org/todo/drop-python-mock-checkdepends/ |
* `--openssl-legacy-provider`: webpack reports an error with OpenSSL 3 [1] as webpack uses md4, which is available only from the legacy provider. Newer webpack adds a wasm implementation of md4 [2], while nbdime uses very old webpack [3]. * Node.js 14.x: some dependencies (ex: @jupyter/ydoc) uses ES modules, which are declared as stable since Node.js 14.x [4] [1] webpack/webpack#14532 [2] webpack/webpack#14584 [3] https://github.com/jupyter/nbdime/blob/2da614b603b694e13fc8d597eef1cc09ff07cb10/packages/webapp/package.json#L44 [4] https://nodejs.org/docs/latest-v14.x/api/esm.html
|
@vidartf I changed some CI settings to fix current errors. Could you re-run failed tests? Also, please tell me if you prefer to split CI changes to a separate pull request. |
|
Thanks for this, and the detailed descriptions in the commit message. If I read this correctly: if we update webpack, we can drop the openssl flag? |
yep |
|
Merging for now, will look at updating webpack later. Thanks! :) |
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Mar 31, 2023
Ref: jupyter/nbdime#651 git-svn-id: file:///srv/repos/svn-community/svn@1431363 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Mar 31, 2023
Ref: jupyter/nbdime#651 git-svn-id: file:///srv/repos/svn-community/svn@1431363 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter is available with Python 3.3 [1], and nbdime requires Python 3.6+ as per setup.py.
This change removes the need of an external library.
[1] https://docs.python.org/3/library/unittest.mock.html