Add notebook 6 server extension support (w/tests) #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I got hit by the error about |
|
|
Adds support for notebook 6 by loudly failing if trying to load nbdime as an nb6 server extension if jupyter_server version >= 2.
node 18, webpack 5, etc.
It has been removed https://about.codecov.io/blog/message-regarding-the-pypi-package/ |
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Apr 23, 2023
* Reorder dependencies following setup.py * Remove no longer needed python-six and python-ipython-genutils [1][2] * Remove npm from makedepends - not needed for a PyPI tarball as the latter includes built frontend artifacts * jupyter-notebook and python-packaging are needed for notebook 6 support only [3] * Drop no longer needed hacks [1] jupyter/nbdime#586 [2] jupyter/nbdime#618 [3] jupyter/nbdime#656 git-svn-id: file:///srv/repos/svn-community/svn@1448348 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Apr 23, 2023
* Reorder dependencies following setup.py * Remove no longer needed python-six and python-ipython-genutils [1][2] * Remove npm from makedepends - not needed for a PyPI tarball as the latter includes built frontend artifacts * jupyter-notebook and python-packaging are needed for notebook 6 support only [3] * Drop no longer needed hacks [1] jupyter/nbdime#586 [2] jupyter/nbdime#618 [3] jupyter/nbdime#656 git-svn-id: file:///srv/repos/svn-community/svn@1448348 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail loudly (but not catastrophically) if trying to load as a server extension for notebook v6, if jupyter_server 2 is installed. It would fail anyways due to base classes being incompatible, but this will produce a clear error message, and stop loading the nbdime handlers.