New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With PYTHONWARNDEFAULTENCODING=true, EncodingWarning occurs #366

Closed

jaraco opened this issue Jun 23, 2023 · 0 comments · Fixed by #371

jaraco commented Jun 23, 2023

Running tests for pip-run, I observe an EncodingWarning after setting PYTHONWARNDEFAULTENCODING per PEP 597:

tests/test_scripts.py::TestNotebookDepsReader::test_one_code_block
  /Users/jaraco/code/jaraco/pip-run/.tox/py/lib/python3.11/site-packages/nbformat/validator.py:102: EncodingWarning: 'encoding' argument not specified
    with open(schema_path) as f:

Probably that should be changed to open(schema_path, encoding='utf-8')

The text was updated successfully, but these errors were encountered:

blink1073 mentioned this issue

Fix encoding warnings #371

Merged

blink1073 closed this as completed in #371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment