Skip to content

Commit

Permalink
Labextension compatibility (#1827)
Browse files Browse the repository at this point in the history
* Fix packages compatibility

* Add test on compatibility

* Fix compatibility test

* Test compatibility only on linux
  • Loading branch information
brichet committed Sep 5, 2023
1 parent ee56010 commit 7922f76
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 20 deletions.
28 changes: 28 additions & 0 deletions .github/workflows/test-extensions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,34 @@ defaults:
shell: bash

jobs:
labextension-compatibility:
runs-on: ubuntu-22.04
timeout-minutes: 10
steps:
- uses: actions/checkout@v3
- name: Install node
uses: actions/setup-node@v3
with:
node-version: '18.x'
# NOTE: actions/setup-python@v2 can make use of a cache within the GitHub
# Action virtual environment and setup extremely fast. 3.9 isn't
# available in this cache as of November 2020.
- name: Install Python
uses: actions/setup-python@v2
- name: Install package
run: |
python -m pip install --upgrade pip wheel setuptools
pip install -e .
pip freeze
- name: Check compatibility
run: |
if [[ $(jupyter labextension list 2>&1 | grep '(python, nbgrader)' | grep ' X') ]]
then
echo "Compatibility error"
jupyter labextension list
exit 1
fi
ui-test:
runs-on: ${{ matrix.os }}
timeout-minutes: 40
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"dependencies": {
"@jupyter-notebook/application": "^7.0.2",
"@jupyter-notebook/tree": "^7.0.2",
"@jupyter/ydoc": "^0.3.4",
"@jupyter/ydoc": "^1.0.2",
"@jupyterlab/application": "^4.0.4",
"@jupyterlab/apputils": "^4.1.4",
"@jupyterlab/cells": "^4.0.4",
Expand Down
24 changes: 5 additions & 19 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -492,20 +492,6 @@ __metadata:
languageName: node
linkType: hard

"@jupyter/ydoc@npm:^0.3.4":
version: 0.3.4
resolution: "@jupyter/ydoc@npm:0.3.4"
dependencies:
"@jupyterlab/nbformat": ^3.0.0 || ^4.0.0-alpha.15
"@lumino/coreutils": ^1.11.0 || ^2.0.0-alpha.6
"@lumino/disposable": ^1.10.0 || ^2.0.0-alpha.6
"@lumino/signaling": ^1.10.0 || ^2.0.0-alpha.6
y-protocols: ^1.0.5
yjs: ^13.5.40
checksum: edd14a01be6ceac437d3ebfb5f7a2d2c8eac60fec91e48d8d2ef2bef9f1423b4350c57dba25b3b043759ffb61b601a3815c1ea56532d1d707e3fbeb5df86b7e6
languageName: node
linkType: hard

"@jupyter/ydoc@npm:^1.0.2":
version: 1.0.2
resolution: "@jupyter/ydoc@npm:1.0.2"
Expand Down Expand Up @@ -993,7 +979,7 @@ __metadata:
languageName: node
linkType: hard

"@jupyterlab/nbformat@npm:^3.0.0 || ^4.0.0-alpha.15, @jupyterlab/nbformat@npm:^3.0.0 || ^4.0.0-alpha.21 || ^4.0.0, @jupyterlab/nbformat@npm:^4.0.4, @jupyterlab/nbformat@npm:^4.0.5":
"@jupyterlab/nbformat@npm:^3.0.0 || ^4.0.0-alpha.21 || ^4.0.0, @jupyterlab/nbformat@npm:^4.0.4, @jupyterlab/nbformat@npm:^4.0.5":
version: 4.0.5
resolution: "@jupyterlab/nbformat@npm:4.0.5"
dependencies:
Expand Down Expand Up @@ -1423,7 +1409,7 @@ __metadata:
languageName: node
linkType: hard

"@lumino/coreutils@npm:^1.11.0 || ^2.0.0, @lumino/coreutils@npm:^1.11.0 || ^2.0.0-alpha.6, @lumino/coreutils@npm:^1.11.0 || ^2.1.2, @lumino/coreutils@npm:^2.1.1, @lumino/coreutils@npm:^2.1.2":
"@lumino/coreutils@npm:^1.11.0 || ^2.0.0, @lumino/coreutils@npm:^1.11.0 || ^2.1.2, @lumino/coreutils@npm:^2.1.1, @lumino/coreutils@npm:^2.1.2":
version: 2.1.2
resolution: "@lumino/coreutils@npm:2.1.2"
checksum: 7865317ac0676b448d108eb57ab5d8b2a17c101995c0f7a7106662d9fe6c859570104525f83ee3cda12ae2e326803372206d6f4c1f415a5b59e4158a7b81066f
Expand All @@ -1447,7 +1433,7 @@ __metadata:
languageName: node
linkType: hard

"@lumino/disposable@npm:^1.10.0 || ^2.0.0, @lumino/disposable@npm:^1.10.0 || ^2.0.0-alpha.6, @lumino/disposable@npm:^2.1.2":
"@lumino/disposable@npm:^1.10.0 || ^2.0.0, @lumino/disposable@npm:^2.1.2":
version: 2.1.2
resolution: "@lumino/disposable@npm:2.1.2"
dependencies:
Expand Down Expand Up @@ -1508,7 +1494,7 @@ __metadata:
languageName: node
linkType: hard

"@lumino/signaling@npm:^1.10.0 || ^2.0.0, @lumino/signaling@npm:^1.10.0 || ^2.0.0-alpha.6, @lumino/signaling@npm:^2.1.1, @lumino/signaling@npm:^2.1.2":
"@lumino/signaling@npm:^1.10.0 || ^2.0.0, @lumino/signaling@npm:^2.1.1, @lumino/signaling@npm:^2.1.2":
version: 2.1.2
resolution: "@lumino/signaling@npm:2.1.2"
dependencies:
Expand Down Expand Up @@ -5458,7 +5444,7 @@ __metadata:
dependencies:
"@jupyter-notebook/application": ^7.0.2
"@jupyter-notebook/tree": ^7.0.2
"@jupyter/ydoc": ^0.3.4
"@jupyter/ydoc": ^1.0.2
"@jupyterlab/application": ^4.0.4
"@jupyterlab/apputils": ^4.1.4
"@jupyterlab/builder": ^4.0.4
Expand Down

0 comments on commit 7922f76

Please sign in to comment.