Don't skip the assignment if a notebook raises an exception

jupyter · Mar 14, 2023 · 90e2874 · 90e2874
1 parent 4865cf8
commit 90e2874
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/nbgrader/converters/base.py b/nbgrader/converters/base.py
@@ -391,7 +391,7 @@ def _handle_failure(gd: typing.Dict[str, str]) -> None:
                         self.convert_single_notebook(notebook_filename)
 
                     # Exceptions that shouldn't interrupt the entire conversion process should go here
-                    # Those that should go in outer try/except
+                    # Those that should interrupt go in the outer try/except
                     except UnresponsiveKernelError:
                         self.log.error(
                             "While processing assignment %s, the kernel became "
@@ -405,6 +405,7 @@ def _handle_failure(gd: typing.Dict[str, str]) -> None:
                         errors.append((gd['assignment_id'], gd['student_id']))
                         _handle_failure(gd)
 
+                    # Raise unhandled exceptions for the outer try/except
                     except Exception as e:
                         raise e