Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter server #1586

Merged
merged 5 commits into from
May 30, 2022
Merged

Jupyter server #1586

merged 5 commits into from
May 30, 2022

Conversation

brichet
Copy link
Contributor

@brichet brichet commented May 18, 2022

This PR is a starting point for using labextensions :

@jtpio jtpio added this to the 0.8.0 milestone May 18, 2022
pyproject.toml Outdated
@@ -1,3 +1,7 @@
[build-system]
requires = ["jupyter_packaging~=0.5.0", "setuptools>=40.8.0", "wheel"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we need to stick to 0.5.x for jupyter packaging here.

Or if it could be bumped to a more recent version, for example: jupyter_packaging~=0.12.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also of note, we will probably soon be able to drop jupyter-packaging and switch to hatch (in a later PR):

jupyterlab/frontends-team-compass#146

@brichet
Copy link
Contributor Author

brichet commented May 20, 2022

It's not ready to be merged yet, this version still uses the notebook_dir (notebook server property) instead of root_dir (jupyter server property).
At this point both servers should be usable, it must be possible to choose between these 2 properties.
I will fix this in a future commit.

Edit :
Fixed in 8110193

…ion (respectively notebook.notebookapp.NotebookApp or jupyter_server.serverapp.ServerApp)
@brichet
Copy link
Contributor Author

brichet commented May 27, 2022

@jhamrick @BertR @jtpio do you think this PR can be merged ?

Copy link
Member

@jhamrick jhamrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Perhaps @jtpio can take another look as well before merging.

@jtpio
Copy link
Member

jtpio commented May 30, 2022

Nice thanks @brichet!

@jhamrick jhamrick merged commit 738ee29 into jupyter:main May 30, 2022
@jtpio
Copy link
Member

jtpio commented May 30, 2022

Also, do we already test that the extensions are loaded and enabled on CI?

Otherwise maybe we should add a check on CI that runs jupyter server extension list and check the extensions are correctly listed?

@brichet
Copy link
Contributor Author

brichet commented May 30, 2022

Also, do we already test that the extensions are loaded and enabled on CI?

Otherwise maybe we should add a check on CI that runs jupyter server extension list and check the extensions are correctly listed?

No, there is no test on the installation and activation of extensions yet. We may add it.

@brichet brichet deleted the jupyter_server branch June 3, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate server extensions to jupyter_server
3 participants