Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create assignment panel only open if a Notebook is visible on main area #1606

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Create assignment panel only open if a Notebook is visible on main area #1606

merged 2 commits into from
Jun 23, 2022

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Jun 20, 2022

This PR improves the behavior of the create assignment widget :

  • If no Notebook is visible in main area, clicking on the button does not open the right panel (instead of opening an empty one)
  • if a notebook is visible, it will be activated (can occur when the main area is split)
  • if the selected tab in main area becomes a tab which is not a Notebook, the create assignment panel is closed

@jtpio jtpio added this to the 0.8.0 milestone Jun 21, 2022
@brichet
Fix an implemantation error which was closing the create_assignment s…
7758d23 
…idebar when the focused cell was changing, instead of focused tab
jtpio
jtpio approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@jtpio
Copy link
Member

jtpio commented Jun 23, 2022

At some point we'll want to start looking into how the extension behaves in Notebook v7 application, which doesn't provide a ILabShell.

But that can be tracked in a separate issue.

@brichet
Copy link
Contributor Author

brichet commented Jun 23, 2022

At some point we'll want to start looking into how the extension behaves in Notebook v7 application, which doesn't provide a ILabShell.

But that can be tracked in a separate issue.

Sure, but I think we'll do it in a separate issue.
For now it's not working with Notebook v7, and doesn't seem to be fully compatible with JupyterLab 4 either.

@jhamrick
Copy link
Member

Nice, thanks!

@jhamrick jhamrick merged commit 677761e into jupyter:main Jun 23, 2022
@brichet brichet deleted the feature/create_assignment branch July 7, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brichet @jtpio @jhamrick