Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker image for demo #1674

Merged
merged 2 commits into from Dec 30, 2022
Merged

Fix Docker image for demo #1674

merged 2 commits into from Dec 30, 2022

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Sep 28, 2022

This PR fix #1668.

  • It installs nodejs=16 (not available on apt) in docker image
  • it pins nbclassic<0.4.0 as currently expected by nbgrader.

If nbclassic is not pinned, the v0.4.0 is first installed with jupyterlab. When installing nbgrader, the v0.4.0 is uninstall in favor of v0.3.7. It seems that it breaks jupyter-nbextension...

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/nbgrader/fix/demo_docker

@brichet brichet added the bugfix label Sep 28, 2022
@brichet brichet mentioned this pull request Sep 28, 2022
@brichet brichet added the bug label Sep 28, 2022
@perllaghu
Copy link
Contributor

Yay... but poodles.... Image builds, but the feedback link is still failing on Binder.

(see #1664 (comment))

@brichet brichet merged commit fc4b1c5 into jupyter:main Dec 30, 2022
@brichet brichet deleted the fix/demo_docker branch March 23, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo not starting
2 participants