Fix validation for failed cells with zero points #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brichet
reviewed
Mar 2, 2023
nbgrader/utils.py
Outdated
| def has_failed(cell: NotebookNode) -> bool: | ||
| """Returns True if the cell contains an output indicative of an error""" | ||
| if not cell.cell_type == 'code': | ||
| raise ValueError("cell is not a code cell, so it can't fail") |
There was a problem hiding this comment.
Suggested change
| raise ValueError("cell is not a code cell, so it can't fail") | |
| return False |
Maybe we don't need to raise here
|
Thanks @tuncbkose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a cell gets full points during validation, check if max_points is 0 and the cell actually failed. Fixes (part of) #1418.
If this looks good, I can also add some related tests.