Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the notification during UI tests, to fix a failing test #1743

Merged
merged 1 commit into from Mar 3, 2023
Merged

Remove the notification during UI tests, to fix a failing test #1743

merged 1 commit into from Mar 3, 2023

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Mar 3, 2023 •
edited

This PR suppresses notifications during UI testing, to prevent some tests from failing because of them.

Fix the first item of #1736

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Binder 👈 Launch a Binder on branch brichet/nbgrader/remove_notifications_UI_tests

@brichet brichet merged commit 1952b87 into jupyter:main Mar 3, 2023
28 of 31 checks passed
@brichet brichet deleted the remove_notifications_UI_tests branch March 3, 2023 11:26
@brichet brichet mentioned this pull request Mar 3, 2023
Closed
@brichet brichet self-assigned this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brichet brichet

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@brichet