New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate nbgrader widgets after they are disposed. #1773
Conversation
I can give it a try.
Any idea how to close the opened tab? |
This is the correct function. nbgrader/nbgrader/tests/labextension_ui-tests/tests/test_assignment_list.spec.ts Line 155 in 05bb458
I think the close icon have the class |
By the way, I submitted an identical pull request two weeks ago (#1756). |
I have now extended the UI tests upon suggestion of @brichet (with a little of refactoring). The tests fail without the patch. @tuncbkose sorry I did not notice the identical issue #1722. I noticed that the bug is still present in the latest release 0.8.2, so I did not check for old issues. :-/ |
The extended tests close the opened tab and open it again
Thanks @ykazakov |
Fixes #1772
I did not add tests to reproduce the issue. This would require a bit more work.