Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selenium deprecation for nbextension tests #1789

Merged
merged 1 commit into from Jun 13, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions nbgrader/tests/nbextensions/conftest.py
Expand Up @@ -186,8 +186,8 @@ def _make_browser(tempdir):
options = webdriver.firefox.options.Options()
options.add_argument('-headless')
options.set_preference('intl.accept_languages', 'en-GB')
browser = webdriver.Firefox(
options=options, service_log_path=os.path.devnull)
service = webdriver.firefox.service.Service(log_path=os.path.devnull)
browser = webdriver.Firefox(options=options, service=service)
browser.set_page_load_timeout(30)
browser.set_script_timeout(30)

Expand Down