Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding --no-execute flag to autogradeapp.py #439

Closed
wants to merge 1 commit into from

Conversation

ellisonbg
Copy link
Contributor

Useful for long running notebooks.

Useful for long running notebooks.
else:
# If execute is False, don't run notebooks or clear output
if pp not in (Execute, ClearOutput):
self.exporter.register_preprocessor(pp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem like no-execute could just be an alias for Execute.enabled=False and ClearOutput .enabled=False instead of a convoluted logic. No ?

@Carreau
Copy link
Member

Carreau commented Feb 15, 2016

Small comment I think you can simplify the implementation.

@ellisonbg
Copy link
Contributor Author

Great points!

On Sun, Feb 14, 2016 at 5:13 PM, Matthias Bussonnier <
notifications@github.com> wrote:

Small comment I think you can simplify the implementation.


Reply to this email directly or view it on GitHub
#439 (comment).

Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com

@jhamrick
Copy link
Member

@ellisonbg I think this looks good, though I like @Carreau 's suggestions. It would probably also be good if you could add some tests for this. I can make a PR against your branch if you'd like, if you're too busy at the moment. Before that, though, I think this needs a rebase against master so that it will get the build fixes I just merged.

@jhamrick jhamrick added this to the 0.3.0 milestone Feb 21, 2016
@Carreau
Copy link
Member

Carreau commented Feb 22, 2016

I can make a PR against your branch if you'd like, if you're too busy at the moment. Before that, though, I think this needs a rebase against master so that it will get the build fixes I just merged

I'll try to see if I can find some grad students to do that this Wednesday.

@jhamrick
Copy link
Member

Great, thanks!

@jhamrick
Copy link
Member

jhamrick commented Mar 3, 2016

Reimplemented as #448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants