-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding --no-execute flag to autogradeapp.py #439
Conversation
Useful for long running notebooks.
else: | ||
# If execute is False, don't run notebooks or clear output | ||
if pp not in (Execute, ClearOutput): | ||
self.exporter.register_preprocessor(pp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seem like no-execute
could just be an alias for Execute.enabled=False
and ClearOutput .enabled=False
instead of a convoluted logic. No ?
Small comment I think you can simplify the implementation. |
Great points! On Sun, Feb 14, 2016 at 5:13 PM, Matthias Bussonnier <
Brian E. Granger |
@ellisonbg I think this looks good, though I like @Carreau 's suggestions. It would probably also be good if you could add some tests for this. I can make a PR against your branch if you'd like, if you're too busy at the moment. Before that, though, I think this needs a rebase against master so that it will get the build fixes I just merged. |
I'll try to see if I can find some grad students to do that this Wednesday. |
Great, thanks! |
Reimplemented as #448 |
Useful for long running notebooks.