Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin jupyter-client #467

Merged
merged 1 commit into from
Mar 10, 2016
Merged

unpin jupyter-client #467

merged 1 commit into from
Mar 10, 2016

Conversation

minrk
Copy link
Member

@minrk minrk commented Mar 9, 2016

Not meant to merge as-is. This is to verify that jupyter/jupyter_client#141 actually works.

Once that's confirmed and the fix released, I'll update this to just unpin jupyter_client.

@jhamrick
Copy link
Member

jhamrick commented Mar 9, 2016

Yay! 🍰

When you update it to just unpin this, would you mind also unpinning it in the flit.ini file?

@jhamrick jhamrick added the bugfix label Mar 9, 2016
@jhamrick jhamrick added this to the 0.3.0 milestone Mar 9, 2016
@minrk
Copy link
Member Author

minrk commented Mar 9, 2016

Forgot about flit. Will do.

We could also blacklist 4.2.0-4.2.1,
and I would probably do that if there were only one bad version.
@minrk minrk changed the title [WIP] Verify test with jupyter-client branch unpin jupyter-client Mar 10, 2016
@minrk
Copy link
Member Author

minrk commented Mar 10, 2016

Should be set.

Carreau added a commit that referenced this pull request Mar 10, 2016
@Carreau Carreau merged commit add269d into jupyter:master Mar 10, 2016
@jhamrick
Copy link
Member

Thanks!

@minrk minrk deleted the verify-client-fix branch March 14, 2016 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants