Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect Tree view to Index.ipynb if it exists #182

Closed
wants to merge 2 commits into from

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Jan 27, 2014

First pass on #181, adding an index page.

I've deployed this to qa and have two samples:

GitHub repository

http://qa2.nb.minrk.net/github/rgbkrk/index.ipynb/tree/master/

Gist with index.ipynb

http://qa2.nb.minrk.net/gist/rgbkrk/8653938


While testing this out, it seems like we don't have redirection to a tree enabled (have to know the magic behind nbviewer's URLs to list a repo). Am I missing something here?

@Carreau
Copy link
Member

Carreau commented Jan 27, 2014

http://qa2.nb.minrk.net/gist/rgbkrk/8653938

gist with only one file show already this file by default :-)

@ellisonbg
Copy link
Contributor

This works as expected. But I agree that we currently don't have a great
URL scheme that makes it easy for people to link to an entire repo. For
example, it would be nice if the following "just worked" when pasted into
our URL form on the home page:

  • ipython = username
  • ipython/ipython = username + repo

But that is a separate issue. I will open up one for that. Thanks for
working on this Kyle!

On Mon, Jan 27, 2014 at 11:25 AM, Matthias Bussonnier <
notifications@github.com> wrote:

http://qa2.nb.minrk.net/gist/rgbkrk/8653938

gist with only one file show already this file by default :-)


Reply to this email directly or view it on GitHubhttps://github.com//pull/182#issuecomment-33410960
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@rgbkrk
Copy link
Member Author

rgbkrk commented Feb 2, 2014

gist with only one file show already this file by default :-)

Yeah, this lets them have multiple files and their own index notebook.

Are people happy with this PR? I feel safe in merging, but don't want to step on toes.

@Carreau
Copy link
Member

Carreau commented Feb 2, 2014

I would prefer to wait to sort how we should do in live notebook and dashboard to have uniform experience.

@ellisonbg
Copy link
Contributor

Yes, based on our discussion at the dev meeting, I think we need a bit more
thought on this one. We will probably do something like this, but have a
few more details to work out. Let's wait and keep talking.

On Sun, Feb 2, 2014 at 10:53 AM, Matthias Bussonnier <
notifications@github.com> wrote:

I would prefer to wait to sort how we should do in live notebook and
dashboard to have uniform experience.

Reply to this email directly or view it on GitHubhttps://github.com//pull/182#issuecomment-33908506
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@ellisonbg
Copy link
Contributor

Here is a PR on ipython/master that implements index.ipynb handling for the live notebook:

ipython/ipython#5001

Question @rgbkrk does this implementation handle all cases of index: index.ipynb, INDEX.ipynb, Index.ipynb?

@rgbkrk
Copy link
Member Author

rgbkrk commented Feb 3, 2014

Yeah, this is case insensitive (I lowercase the actual filename to check). First* file that matches index.ipynb case insensitively wins. Index.ipynb, index.ipynb and InDeX.iPYnb all resolve properly.

@Carreau
Copy link
Member

Carreau commented Feb 3, 2014

So you cannot force the view of the tree? And goodby seeing directory strucures and ipynb bellow like on github?

Envoyé de mon iPhone

Le 3 févr. 2014 à 03:31, "Brian E. Granger" notifications@github.com a écrit :

Here is a PR on ipython/master that implements index.ipynb handling for the live notebook:

ipython/ipython#5001

Question @rgbkrk does this implementation handle all cases of index: index.ipynb, INDEX.ipynb, Index.ipynb?


Reply to this email directly or view it on GitHub.

@rgbkrk
Copy link
Member Author

rgbkrk commented Feb 3, 2014

So you cannot force the view of the tree? And goodby seeing directory strucures and ipynb bellow like on github?

No no, directory structures can still be seen.

This just gives people an option to create their own index rather than our directory view, by creating "index.ipynb".

@rgbkrk rgbkrk mentioned this pull request Feb 26, 2014
@minrk
Copy link
Member

minrk commented Mar 20, 2014

we aren't going to redirect to index.ipynb for now.

@minrk minrk closed this Mar 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants