Merge pull request #3195 from areading314/ar/limit_autcomplete_elements

Limit length of GUI autocomplete to 1000
jupyter · Jan 19, 2018 · 31215b8 · 31215b8
2 parents 6526a19 + 426346f
commit 31215b8
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/notebook/static/notebook/js/completer.js b/notebook/static/notebook/js/completer.js
@@ -306,7 +306,8 @@ define([
     };
 
     Completer.prototype.build_gui_list = function (completions) {
-        for (var i = 0; i < completions.length; ++i) {
+        var MAXIMUM_GUI_LIST_LENGTH = 1000;
+        for (var i = 0; i < completions.length && i < MAXIMUM_GUI_LIST_LENGTH; ++i) {
             var opt = $('<option/>').text(completions[i].str).addClass(completions[i].type);
             this.sel.append(opt);
         }